Define more GT2560 fan pins#16235
Merged
thinkyhead merged 4 commits intoMarlinFirmware:bugfix-2.0.xfrom Dec 16, 2019
Vertabreak:PR2
Merged
Define more GT2560 fan pins#16235thinkyhead merged 4 commits intoMarlinFirmware:bugfix-2.0.xfrom Vertabreak:PR2
thinkyhead merged 4 commits intoMarlinFirmware:bugfix-2.0.xfrom
Vertabreak:PR2
Conversation
Bugfix 2.0.x source update
Bugfix 2.0.x
Bugfix 2.0.x
Contributor
|
They were disabled in PR #13036, but no reason was given. |
Contributor
Author
|
so can we turn them back on then? |
Contributor
|
Let's ask @ratmole |
Contributor
Author
|
i have several users that make use of these pins on there GT2560V3 boards it just seems strange they would be turned off. |
Contributor
|
They weren't there before. @ratmole added them but, I guess, kept them disabled out of fear of conflicts. |
Contributor
Author
|
i have them enabled on both my A10 & A10M right now with zero conflict. |
Contributor
|
I understand. I'm just speculating the reasoning behind it. I'm in favor of enabling as those pins are clearly not set to anything else in the pin file. |
Contributor
Author
|
just making it clear that i did verify it did not make anything explode on my own hardware. |
Member
|
It may be that the current machines that ship with the GT2560 aren't using the other fans. By not defining the pins, the code ends up slightly smaller, without any reference to the unused fans. But it has been customary in Marlin to define all fan pins and compile in code for them even if they are not used. |
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 16, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 16, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 16, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 16, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 16, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 16, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 16, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 16, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 16, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 16, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 16, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 16, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 16, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 17, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 17, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 17, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 17, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 17, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 17, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 17, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 17, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 17, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 17, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 17, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 18, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 18, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script * Move AutoBuildMarlin to its own repo
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 18, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script * Move AutoBuildMarlin to its own repo
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 18, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script * Move AutoBuildMarlin to its own repo
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 18, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script * Move AutoBuildMarlin to its own repo
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 18, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script * Move AutoBuildMarlin to its own repo
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 18, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script * Move AutoBuildMarlin to its own repo
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 18, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script * Move AutoBuildMarlin to its own repo
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 18, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script * Move AutoBuildMarlin to its own repo
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 18, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script * Move AutoBuildMarlin to its own repo
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 18, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script * Move AutoBuildMarlin to its own repo
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 18, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script * Move AutoBuildMarlin to its own repo
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 18, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script * Move AutoBuildMarlin to its own repo
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 18, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script * Move AutoBuildMarlin to its own repo
LinoBarreca
pushed a commit
to LinoBarreca/Marlin
that referenced
this pull request
Dec 18, 2019
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 18, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script * Move AutoBuildMarlin to its own repo
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 18, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script * Move AutoBuildMarlin to its own repo
pull bot
added a commit
to anttix/Marlin
that referenced
this pull request
Dec 18, 2019
* Define more FAN pins for GT2560 (MarlinFirmware#16235) * Tweak E180 config * Update product links * [cron] Bump distribution date * Add dev-2.1.x to 'mfinfo' script * Move AutoBuildMarlin to its own repo
Contributor
had them disabled because they where not used on my printer :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define three FAN pins for GT2560.